Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azbl/875 Fix and hyperlink PA horticultural society on homepage. #905

Conversation

AZBL
Copy link
Contributor

@AZBL AZBL commented Sep 23, 2024

This request:

  1. Changes Pennsylvania Horticulture Society to Pennsylvania Horticultural Society on homepage.
  2. Creates a hyperlink for the text Pennsylvania Horticultural Society to https://phsonline.org/

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vacant-lots-proj ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 4:50pm

@AZBL
Copy link
Contributor Author

AZBL commented Sep 23, 2024

Comment on lines 145 to 152
neighborhoods for decades. Large organizations like the
<a
target="_blank"
rel="noopener noreferrer nofollow"
href="https://phsonline.org/"
className="default"
>
Pennsylvania Horticultural Society
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add space between "the" and "Pennsylvania."

Screen Shot 2024-09-23 at 11 44 00 PM

@CodeWritingCow CodeWritingCow requested review from bacitracin and removed request for zigouras September 24, 2024 03:46
Copy link
Collaborator

@CodeWritingCow CodeWritingCow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AZBL, the society's name has been corrected, and the new link opened correctly. Just add a space between "the" and "Pennsylvania," and I'll approve this PR. Thanks!

@AZBL
Copy link
Contributor Author

AZBL commented Sep 24, 2024

@CodeWritingCow I added the space so hopefully it's good to go.

…-hyperlink-pa-horticultural-society-on-homepage
@nlebovits nlebovits removed the request for review from zigouras September 24, 2024 17:00
@nlebovits nlebovits merged commit 66b8ceb into CodeForPhilly:staging Sep 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants